fix: BlockHeaderSnapshot #2432
Closed
fix: BlockHeaderSnapshot #2432
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the type of the field parentBeaconBlockRoot in BlockHeaderSnapshot to be an (optional) String instead of a Bytes32 instance. This is to avoid decoding issues because the GSONDecoder is not aware of the Bytes32 type.
The clique consensus protocol was only used prior to shanghai, hence we cannot extract key information from block headers generated from Shanghai nodes and onwards.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| this.baseFee.ifPresent(baseFee -> builder.baseFee(Wei.fromHexString(baseFee))); | ||
|
|
||
| this.parentBeaconBlockRoot.ifPresent( | ||
| root -> builder.parentBeaconBlockRoot(Bytes32.fromHexString(root))); |
There was a problem hiding this comment.
Bug: Block Header Inconsistency Due to Null Handling
The toBlockHeader method now conditionally sets parentBeaconBlockRoot. If the root is empty, the builder method isn't called, which differs from the original code that explicitly passed null. This can cause the BlockHeaderBuilder to treat the field as "not set" instead of "set to null," leading to inconsistent header reconstruction and potentially breaking round-trip conversion.
letypequividelespoubelles
approved these changes
Oct 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Make
parentBeaconBlockRootoptional hex inBlockHeaderSnapshot, add Sepolia Prague test config, and select mining beneficiary by fork (post-Shanghai uses coinbase).BlockHeaderSnapshot.parentBeaconBlockRootfromBytes32toOptional<String>and serialize as hex viamap(Bytes::toHexString).toBlockHeader(), setparentBeaconBlockRootonly when present (Bytes32.fromHexString(...)); keepCliqueBlockHeaderFunctionssetup.header.getCoinbase(), otherwiseCliqueHelpers.getProposerOfBlock(...).SEPOLIA_TESTCONFIG(fork)andSEPOLIA_PRAGUE_TESTCONFIGfor Prague on Sepolia.Written by Cursor Bugbot for commit add5f6a. This will update automatically on new commits. Configure here.